Okay I need to pick another var name.

Thanks for your PR.
Sometimes additional problems arise after deprecated function changes, which may affect the merge of high-priority fixes. Our guidebook says to avoid using deprecated functions, not prohibit. @BillyONeal Please help to confirm whether we need to error out the deprecated function?

Sometimes additional problems arise after deprecated function changes, which may affect the merge of high-priority fixes. Our guidebook says to avoid using deprecated functions, not prohibit. @BillyONeal Please help to confirm whether we need to error out the deprecated function?

The maintainer guidelines describe it as a suggestion because we did not want to force people to make unrelated changes for simple version updates and similar. There was still a lot of use of the deprecated function in the curated registry, and forcing people who aren't interested in overall 'cleanup' of code they don't own in our registry makes it less nice to be a contributor.

Now that there are no calls to the deprecated functions left in the tree, I think we can block it entirely.

Note that CI doesn't provide a means of testing this change because it only runs some of these scripts from master rather than from the PR branch.

Note that CI doesn't provide a means of testing this change because it only runs some of these scripts from master rather than from the PR branch.

@BillyONeal Can't you trigger a manual run in the vcpkg.ci pipeline (no parent hashes, no caching)?

@BillyONeal Can't you trigger a manual run in the vcpkg.ci pipeline (no parent hashes, no caching)?

I can trigger manual runs of the Azure Pipelines stuff against forks, but not Actions stuff against forks. (Because Actions can write-back to the repo and Pipelines can't, Actions only ever runs trustedPR.yml from master, not from the fork)

To meaningfully test changes to the Actions stuff one needs to setup Actions in their own fork with main pointing to the base commit SHA of the PR, and then make PRs into it intentionally triggering problems to show that they are problems.

@JackBoosY Note: I will be converting your PR to draft status. Please reactivate this PR once it is ready for review. Thanks.

@BillyONeal Please retest CI scripts.

Can you test this on your repository with an Actions pipeline? See Billy's comment on how to do so

Looks good:

• test good #31692 Test demo good JackBoosY/vcpkg#7
• Test deprecated function vcpkg_apply_patches #31690 test deprecated vcpkg_apply_patches JackBoosY/vcpkg#8
• test deprecated functions vcpkg_*_cmake #31691 test vcpkg_*_cmake JackBoosY/vcpkg#9